Open
Conversation
rcosta358
changed the title
rcosta358
added
enhancement
rcosta358
changed the title
rcosta358
force-pushed
the
substitute-internal-vars
branch
from
3f184df to
cc86f95
Compare
CatarinaGamboa
approved these changes
Mar 27, 2026
Collaborator
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
There was a problem hiding this comment.
Great start of the symb propagation algorithm! Just check if the origins are all that they are supposed to in a follow-up pr.
The example was:
b_7 == a_ 3 && a_3 + 1 > 0 : this has origin but
b_7 == a_ 3 && b_7 + 1 > 0 : this does not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially covers #162, by substituting internal variables (e.g.,
#b_1) with user facing variables (e.g.,b), which results in simpler expressions, even without the full constraint simplification. Also, when an internal variable equals another internal variable, the lower-counter variable is substituted with the higher-counter one.Example
Before
No expansions:
After
Before expanding:
After expanding: